Jochen Hilgers
Jochen Hilgers
I created the linked PR, where the returned error is changed from `syscall.EPERM` to `os.ErrPermission`. I think this is more idiomatic to the std package This code creates a permission...
@bobbrow can you please approve the workflow run... I was not able to get `yarn run unitTests` working on my machine so it would be nice to know it there...
> Some things are broken if `binaryDir` is not set. I believe cmake defaults to use the cwd when a build directory is not supplied, but we currently set the...
@bobbrow sounds good! Feel free to go on :slightly_smiling_face:
Yes, I agree to the CLA I have no idea how that happened... I noticed it, but I was unable to sign again
Thanks for your answers! > if the generator is not defined somewhere in the inheritance, the preset should be considered invalid and not available for use I think this is...
> Sorry, I mispoke. You are correct. The behavior changed in v3. We might not have fixed the extension to deal with that yet. I don't believe the extension has...
@bobbrow I am working on the PR (https://github.com/microsoft/vscode-cmake-tools/compare/main...jochil:vscode-cmake-tools:v3-preset-default-generator) but I have a few questions: 1. The unit tests are not running on my system... I get a lot of this...
@bobbrow thanks for the answers... with 3. I was wrong of course, no need for a generator here :slightly_smiling_face: I created the PR: https://github.com/microsoft/vscode-cmake-tools/pull/2748 Thanks a lot for the support
> Hi @jochil, I have left some comments, the rest looks good! I'll merge it when you've fixed the comments rocket @MarvinJWendt Thanks for the feedback... I fixed the comments