vscode-cmake-tools icon indicating copy to clipboard operation
vscode-cmake-tools copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

fix(presets): support optional generator for configure presets >= v3

Open jochil opened this issue 2 years ago • 1 comments

Fixes #2734

This change addresses item #2734

This changes behavior

The following changes are proposed:

  • Adding a configure preset (>=v3) that has no generator as a test case
  • Remove requirement and fallback for a generator if preset is >= v3

jochil avatar Sep 15 '22 13:09 jochil

CLA assistant check
All CLA requirements met.

ghost avatar Sep 15 '22 13:09 ghost

@bobbrow can you please approve the workflow run... I was not able to get yarn run unitTests working on my machine so it would be nice to know it there are some things waiting for a fix :)

jochil avatar Sep 23 '22 08:09 jochil

Some things are broken if binaryDir is not set. I believe cmake defaults to use the cwd when a build directory is not supplied, but we currently set the cwd to binaryDir which doesn't have a value. An update would need to be made to the extension to handle this properly. I think it's easiest to just keep the code that assigns a default value for the binaryDir.

bobbrow avatar Sep 23 '22 22:09 bobbrow

Some things are broken if binaryDir is not set. I believe cmake defaults to use the cwd when a build directory is not supplied, but we currently set the cwd to binaryDir which doesn't have a value. An update would need to be made to the extension to handle this properly. I think it's easiest to just keep the code that assigns a default value for the binaryDir.

@bobbrow Ok, perfect... I updated the PR and reverted the binaryDir changes

jochil avatar Sep 26 '22 12:09 jochil

@jochil I pushed a commit into your fork that fixes a problem with setting presets that don't have generators set. I also added an entry to the changelog for this improvement. Please let me know if you approve of the changes and then we'll get this in.

bobbrow avatar Sep 29 '22 17:09 bobbrow

@bobbrow sounds good! Feel free to go on :slightly_smiling_face:

jochil avatar Sep 29 '22 18:09 jochil

For some reason the license/cla task is not reporting that you signed the Contributor License Agreement. But at the same time I see this: image

We can push this PR through, but I wanted to double check with you that you agree to the CLA before doing so.

bobbrow avatar Oct 03 '22 21:10 bobbrow

Yes, I agree to the CLA

I have no idea how that happened... I noticed it, but I was unable to sign again

jochil avatar Oct 04 '22 06:10 jochil