João Thallis

Results 3 comments of João Thallis

> Cool. Was this done with the generation script? No, I applied the changes manually verifying the spec. Is that [this script](https://github.com/open-telemetry/opentelemetry-erlang/blob/main/apps/opentelemetry_semantic_conventions/generate.sh)?

> Should I prefix everything with "oban.*" for these attributes? Reading [the spec](https://opentelemetry.io/docs/specs/semconv/messaging/messaging-spans/#messaging-attributes) it is not specifying that other attributes should start with `messasing`. But the attributes that are in...

What about use [guards](https://hexdocs.pm/elixir/guards.html) in similar cases to decrease the amount of function clauses? Example, from: https://github.com/patrykwozinski/strong_migrations/blob/248adce6de3a341eb5800cc980583585d806daae/lib/strong_migrations/parser.ex#L34-L40 to: ```elixir defp parse_body([{:@, _, [{option, _, [true]}]} | tail], acc) when option...