opentelemetry-erlang-contrib
opentelemetry-erlang-contrib copied to clipboard
open-telemetry
fix: setting oban attributes
Should I prefix everything with "oban.*" for these attributes thou? I prefer to do
Should I prefix everything with
"oban.*"for these attributes thou? I prefer to do
You can add that to this. Might as well get it done since we're touching it.
@tsloughter @bryannaegele is there anything I need to do to get this to the finish line?
@joaothallis anything else?
I am wondering how to get this to the finish line
Should I prefix everything with "oban.*" for these attributes?
Reading the spec it is not specifying that other attributes should start with messasing. But the attributes that are in the spec they can not have the prefix oban.
You're going to kill me but would you mind poking at this test that started failing with newer Oban after I bumped it? I think the test just needs to be updated but I'm not an Oban expert
https://github.com/open-telemetry/opentelemetry-erlang-contrib/issues/287
@bryannaegele https://github.com/sorentwo/oban/pull/1035 it needs to be fixed in the Oban side, it was removed by mistake