Joakim Erdfelt

Results 258 comments of Joakim Erdfelt

Keep in mind that the prior Loom support PR #8035 still exists and is still open * #8035

Looks like `jetty-p2` from Jetty version 10.0.10 was generate using ... ``` 2.7.4 org.eclipse.tycho tycho-p2-repository-plugin ${tycho-version} ``` https://github.com/eclipse/jetty.project/blob/jetty-10.0.x/jetty-p2/pom.xml Is that version stable?

Is Jetty 10.0.11 the same?

Jetty 9.x is now at End of Community Support. * https://github.com/eclipse/jetty.project/issues/7958 Does this happen with Jetty 10.x? If you cannot upgrade, know that Commercial Support for Jetty 9.x is offered...

Initial impression is that it looks like a concurrency issue (race?). I wonder what the `Request._timestamp` is for those requests? Were they processed before or after the graceful shutdown occurred?

The removal of duplicate command line entries seems to be biting you. What happens if you cheese it in one line instead? ``` --add-opens java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.util=ALL-UNNAMED --add-opens java.base/sun.nio.ch=ALL-UNNAMED --add-opens...

It's a cheesy workaround (hack). I think that when you pass the `--dry-run` output to java, (via a shell?) the `\ ` (escaped space) is basically always a space. We...

Here's an alternative declaration, using the `[jpms]` module. ``` [description] Custom JVM Parameter [tags] jvm [exec] -server -XX:+AlwaysPreTouch -XX:+PrintFlagsFinal -XshowSettings:properties -XX:InitialRAMPercentage=80 -XX:MinRAMPercentage=80 -XX:MaxRAMPercentage=80 -XX:+ExitOnOutOfMemoryError -Djava.net.preferIPv4Stack=true -Dnetworkaddress.cache.ttl=0 -Dnetworkaddress.cache.negative.ttl=0 --illegal-access=warn ${JAVA_OPTIONS_INHERIT} ${JAVA_OPTIONS_ADDITIONS}...

@sbordet what do you think about having `--dry-run` output the `[jpms]` section details even if `--jpms` isn't used?