jetty.project icon indicating copy to clipboard operation
jetty.project copied to clipboard

Resource.getAllResources() will hang forever if symlink loop exists within resource directory.

Open lachlan-roberts opened this issue 2 years ago • 4 comments

If there is a circular symlink directory structure somewhere within the resource directory, calling getAllResources() will never complete.

I did a flamegraph while this was happening and getAllResources() was on the stacktrace about 30 calls deep from recusing into other resources.

lachlan-roberts avatar Aug 03 '21 01:08 lachlan-roberts

Does it hang forever or stack overflow? eitherway, it needs to be fixed. We have loop detection elsewhere.

gregw avatar Aug 03 '21 02:08 gregw

It didn't stackoverflow for me after a few minutes but didn't seem to be progressing at all. I guess it probably would have stackoverflowed if it was left running for a long enough time.

lachlan-roberts avatar Aug 03 '21 02:08 lachlan-roberts

This issue has been automatically marked as stale because it has been a full year without activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Aug 04 '22 00:08 github-actions[bot]

This is being addressed in Jetty-12

joakime avatar Aug 04 '22 00:08 joakime

This issue has been automatically marked as stale because it has been a full year without activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Aug 06 '23 00:08 github-actions[bot]

@joakime is this fixed?

sbordet avatar Aug 06 '23 07:08 sbordet

@sbordet I think this is fixed, but I'll check again after the 12.0.0 release effort.

joakime avatar Aug 07 '23 21:08 joakime

@joakime bump

sbordet avatar Sep 23 '23 08:09 sbordet