Joseph Liu

Results 28 comments of Joseph Liu

I second the above, `timespan` would also be something you might consider as well. `time` is definitely misleading and should be changed though.

Re: calling `IncreaseCheckGenericAPICall` per-iteration, I believe the current approach is preferable as it provides a fixed limit on how many reactions can be fetched, whereas your suggestion would make it...

I think your points make sense (but I'm still not convinced either way, unfortunately :P) Gonna mark this as draft to make sure it isn't merged for now & wait...

(Note: I've already stated this privately — this comment is just for the benefit of possible reviewers considering the problem at hand.) My thoughts on whether full messages or IDs...

Hi @ashishjh-bst! Unfortunately I don't think this is ready for merging without more work. (In particular, the UI could use some polishing.) Due to school I'm rather busy and don't...

Actually, not sure if https://github.com/jonas747/yagpdb/commit/1772fe30bcd4a3849781e3ee92cb54b75f78e433 fully resolves this -- as far as I can see the issue will still occur if the target member is higher than the bot. WDYT...

Addressed in https://github.com/jonas747/yagpdb/pull/922/commits/a4b3e4dad6562fb4b604e3fb90b8bb46b456a494, trigger is now not included in the final count. Also during tests it looked like this actually still adds one even if triggered by `exec/execAdmin` (despite the...

Ah OK. Just to clarify, would you like this to manually delete the trigger message in `AdvancedDeleteMessages` instead of including it in the bulk delete, or only include it in...