yagpdb icon indicating copy to clipboard operation
yagpdb copied to clipboard

moderation: check bot hierarchy before performing kick/ban

Open jo3-l opened this issue 3 years ago • 6 comments

Similar to https://github.com/jonas747/yagpdb/pull/887, but for kick and ban (totally forgot about this, otherwise I would've included it in the original PR 😄). This is a slightly more annoying/confusing issue for users - kick and ban would still send a moderation DM if the bot did not have sufficient permissions to moderate the user. Works fine on selfhost, as far as I can see.

jo3-l avatar May 03 '21 01:05 jo3-l

this has conflicts now

jogramming avatar May 04 '21 22:05 jogramming

Should be fixed now @jonas747

jo3-l avatar May 04 '21 22:05 jo3-l

Not needed after https://github.com/jonas747/yagpdb/commit/1772fe30bcd4a3849781e3ee92cb54b75f78e433

jogramming avatar May 10 '21 13:05 jogramming

Actually, not sure if https://github.com/jonas747/yagpdb/commit/1772fe30bcd4a3849781e3ee92cb54b75f78e433 fully resolves this -- as far as I can see the issue will still occur if the target member is higher than the bot. WDYT @jonas747? Happy to modify this PR to just add that fix / keep it closed if you don't think it's worth the additional complexity 😄

jo3-l avatar May 11 '21 03:05 jo3-l

I'll reopen, but we only need that one check then

jogramming avatar May 19 '21 14:05 jogramming

Should be good now, just tested.

jo3-l avatar May 19 '21 17:05 jo3-l