Jonas Nyrup

Results 305 comments of Jonas Nyrup

I don't think we have come to a conclusion yet. (I apologize for the long delay from my side) I've moved the proposal `IgnoringNewlineStyle` to #2612 to separate the discussion...

I find the approach interesting because it treats the json as _json structures_ and not C# structures. I.e. respecting that the JSON data types are: string, number, object, array, boolean...

I don't know what `AsyncResult()` is supposed do :thinking: > `await foo.GetSomething().AsyncResult().Should().BeWhatever();` #1478 added `WithResult` to help for the simple cases. We don't want to make async variants of everything...

For every complaint Qodana has, please think about whether the change is justified. Qodana is a tool not the truth.

Thanks for reporting this. This is due to [Task.WhenAny](https://github.com/fluentassertions/fluentassertions/blob/43cdbb2e415b6e8f2d5a69b734d416a880c3595b/Src/FluentAssertions/Specialized/AsyncFunctionAssertions.cs#L287-L309) swallowing `OperationCanceledException` and returning a canceled exception instead of a faulted exception. I have some ideas how to workaround this in...

> For the record: it seems that the Task.Delay(x) does not have any effect on the outcome. That is only need to ensure the exception happens after a call to...

I don't know or recall why #1416 used `SubsequentOrderingAssertions` in `GenericCollectionAssertions` instead of `SubsequentOrderingGenericCollectionAssertions`. The latter retains `TCollection` whereas the former uses `IEnumerable` which `TCollection` is constrained to. Could we...

> > Could we use `SubsequentOrderingGenericCollectionAssertions` instead of `SubsequentOrderingAssertions`? > > I don't have any preference regarding the naming. I was simply wondering why it needed so many levels of...

I really like that we revise if the default of only looking at the declared types is still the right choice 👍 I tried removing `RespectingRuntimeTypes` and `RespectingDeclaredTypes` and surprisingly...

> > If we discover properties based on the runtime type, which of the two `Name` properties should we favor? > > In #2152, I've chosen to prefer the normal...