Jonas Nyrup

Results 305 comments of Jonas Nyrup

`AssertionEvaluator`? In any case I would avoid the `Fluent` prefix as that is about _how_ it does something compared to _what_ it does.

> > which would be a breaking change? > > Correct. Although that interface is only `public` because of technical constraints. It's not supposed to be used outside the library....

My current vote is on doing nothing. Every new type potentially clashes with other types, that's why we have namespaces. Renaming to `IStopWatch` shifts the _potential_ conflict from being with...

We had a similar discussion in #2263, where I also added some additional use cases and benefits for having `Satisfy` available on single objects in addition to collections. I like...

> A next step would be to dig into which XyzAssertions (perhaps multiple) this should be available from. IIRC [this](https://github.com/fluentassertions/fluentassertions/blob/8c2ae2a551460e45206ccf110c51d84a34db3e73/Tests/FluentAssertions.Specs/AssertionExtensionsSpecs.cs#L76C24-L94) lists all root Assertion types and from that it seems...

First, thanks for the detailed and kind description ❤️ I see how `Excluding()` being ignored when FA choose to compare `T` using value semantics is not intuitive. It seems to...

Even though we technically already support comparing against `NaN` using `Be`, I find this a nice little addition. https://github.com/fluentassertions/fluentassertions/blob/daebdf3c107afe5293e17f453d8b5af1705a6c26/Tests/FluentAssertions.Specs/Numeric/NumericAssertionSpecs.Be.cs#L264-L272 Compared to using `Be`, `BeNaN` will make the test more resistant,...

TLDR; Use `float.IsNaN()` to check if a value _is_ NaN. There are different kinds of equality here. https://learn.microsoft.com/en-us/dotnet/api/system.double.op_equality?view=net-8.0#remarks > If two [Double.NaN](https://learn.microsoft.com/en-us/dotnet/api/system.double.nan?view=net-8.0#system-double-nan) values are tested for equality by using the...

This problem is not unique to records but memberless types in general, e.g. #2391. The general question is how to compare memberless objects? * Structural equivalency implies that it's equivalent...

Wondering whether enabling `IgnoringAllNewlines` means that "cashew nuts" and `cash\r\new nuts` are considered equivalent. In implementation details, whether `"\n"` and `"\r\n"` are replaced with: * `""` or * `" "`...