Joseph Musser

Incorrect "CS8602 Dereference of a possibly null reference" after pattern-matching through a derived type

10

**Version Used**: VS 17.10.0-p2 and [SharpLab](https://sharplab.io/#v2:C4LgbgpgTglgZgTwDQBMQGoA+YCGUAEK+AvPgHYQDu+AItDJEQN74BiA9uyeVfuwEYArCAGNgACgCU+AL4BuALAAoZQH1u4gcLGSiAZ0oxgIgBbKmy/Fdr1G+Fh3Yh8AFlkkAfPgAMSS9YB6APxAArJAeD/8AGEAZQAOADZvACYbKAg4aAgyEQg+OHwcfAAHdj09GH4AGwRyAFdKyvw0jLTsiAA6fysg616+/utAZMIu/AAhHD1ch05nFhl8fPniLzh2gHEIYAAJCZNI9hQIKT8lXvVlnxP5ZWUAAQBmfFuU8cnzEYe+IVFgAH42Tj2fAAc02cnwk2A4JkyhhKiUn2eqQYECIzleEEUSiAA=) The repro disappears if the pattern matching is done via `Base` instead of `Derived` or if `Foo` is not read in the `Derived` property...

Add detailed design to clarify the field keyword spec and incorporate all LDM decisions

4

Motivated by noticing missing scenarios on SharpLab for the feature branch. @CyrusNajmabadi indicated that this may need to go through LDM.

Improve user quality of life when debugging assertions in VS by not embedding the PDB

1

Fixes #769 @JosephWoodward When publishing the .nupkg to a feed, just make sure that the .snupkg is in the same directory as the .nupkg file and the right thing will...

Enabling all maintainers to perform all maintenance tasks for Shouldly

5

@shouldly/core This is high priority for me given the docs site being down for months (#860). Given that no single person has guaranteed time to resolve problems in a timely...

We should simply never print out the exact same string for both "should be" and "but was" when the failed assertion is that the objects didn't compare as equal. This...

Obsolete the Should.Throw overloads that take Task instead of Func<Task>

1

(Broken out of https://github.com/shouldly/shouldly/issues/753) The presence of this overload is a pit of failure when asserting exceptions like ArgumentException that mean "the caller should have known better," where the exception...

Update maintainer credits in readme and NuGet package authors

4

What is the current list of maintainers? @JakeGinnivan, @josephwoodward, @jnm2, @slang25? @SimonCropp You just published a package in August, are you in or out? :D I'd like the readme and...

Embedded PDB causes VS to jump to Shouldly internals instead of user test code when debugging assertions

6

This is caused by VS not following the "Just My Code" setting and treating any DLL that contains embedded PDB as the user's code. We had the same problem at...

ShouldAllBeEqual for enumerables

4

If you want to assert that no two values differ in an enumerable, it looks a little round-about: ```cs enumerable.Distinct().ShouldHaveSingleItem(); ``` And the message isn't as direct: ``` should have...

Analyzer for the hard-to-spot expr?.Prop.ShouldBe(x)

4

`?.` is a natural habit that kicks in here, but it doesn't have the intended effect when `expr` is null: ```cs expr?.Prop1.ShouldBe(x); expr?.Prop2.ShouldBe(y); ``` I can't think of a way...