Joseph Musser

Embed engine assemblies

5

Similar to https://github.com/nunit/nunit3-vs-adapter/pull/541, we should consider embedding all other assemblies that might conflict with user test project dependencies. https://github.com/nunit/nunit3-vs-adapter/issues/573 has a short-term fix by catching up the version, but this...

Execute explicit tests using the TestCaseFilter argument on command line

17

Following on from [#47](https://github.com/nunit/nunit3-vs-adapter/issues/47#issuecomment-367164204), we [decided in 3.10](https://github.com/nunit/nunit3-vs-adapter/issues/47#issuecomment-366818938) to add the `Explicit` UI grouping header for test cases that are explicit or have an explicit ancestor, and we made the...

No error is reported in Text Explorer if the test assembly fails to load.

1

If a missing dependency causes a FileNotFoundException in the project being tested, the adapter immediately quits without updating any test results. Is there some way it could report a failure...

Tool to download each URL and verify each hash

2

At NUnit, we want to be able to guarantee that a release does not go out unless the commit is pushed to GitHub and that each download hashes correctly so...

I often refactor between these two forms: ```cs Foo(new[] { item1, item2, item3, item4, item5 }); ``` ```cs somethingMuchMuchLongerThatCausesMeToWantToWrap.Foo(new[] { item1, item2, item3, item4, item5 }); ``` I don't want...

"Read out of buffer" in DecodeForwardIteratorRecord

3

One of the PDB's I'm processing throws this InvalidOperationException. ``` Microsoft.DiaSymReader.Converter.dll!Microsoft.CodeAnalysis.Debugging.CustomDebugInfoReader.ReadInt16(System.Collections.Immutable.ImmutableArray bytes, ref int offset) Line 551 C# Microsoft.DiaSymReader.Converter.dll!Microsoft.CodeAnalysis.Debugging.CustomDebugInfoReader.DecodeForwardIteratorRecord(System.Collections.Immutable.ImmutableArray bytes) Line 209 C# Microsoft.DiaSymReader.Converter.dll!Microsoft.DiaSymReader.Tools.PdbConverterWindowsToPortable.Convert(Microsoft.DiaSymReader.ISymUnmanagedReader5 symReader, System.Reflection.PortableExecutable.PEReader peReader, System.IO.Stream targetPdbStream, System.Reflection.Metadata.BlobContentId...

PDB0009 Invalid type name

8

When converting Windows PDBs to portable PDBs, I'm getting this diagnostic: > PDB0009: token 0x06000DDC: Invalid type name specified in StateMachineTypeName custom debug information: `d__0` How should I address this...

Option to make a single package version support multiple versions of Roslyn

5

StrongInject is gaining the ability to build for both Roslyn 3.8 and 4.0 in the same package: https://github.com/YairHalberstadt/stronginject/pull/181. Another package that does the same thing is https://github.com/reactiveui/refit. A similar (but...

Detect treatment of CategoryAttribute and others as though they apply only within the current attribute list

6

This has come up more than once, though I'm only able to find this one right now: https://github.com/nunit/nunit/issues/3531#issuecomment-624206302 There should be a warning that code like this is misleading. Attribute...

Warn if timeout is used with a parallelizable test

1

Had the idea after reading https://github.com/nunit/nunit/commit/6be37033ea65f15bd7267aa841a1abb47f6353da#commitcomment-30439403. If TimeoutAttribute is used on a test that is allowed to run in parallel, it can exacerbate the unreliable nature of timing-based tests when...