James Muehlner
James Muehlner
Alright, this is all tested and working!
Oops, sorry. Not sure what happened there. They should all be gone now. > Beware a bunch of unrelated commits snuck in here: > > 
> Beware also that the merge of the other KSM-related change has resulted in this conflicting. It'll probably need to be rebased. Rebased!
Awesome! Having a look.
As with https://github.com/apache/guacamole-client/pull/668, I have a few minor nitpicks, but this overall looks pretty good to me. I'm curious if @mike-jumper has any thoughts.
Hey Nick! So I've had a more thorough look through this and the [backend changes](https://github.com/apache/guacamole-server/pull/358/files#diff-cec0f31d33a52d11818f03d91a6076415f717f58d61ab09b73009df961d8238fR685-R686) and I have a couple of thoughts. First off, I really like this idea. Having...
Hey Nick! I really like the direction this is going. It looks a lot better already. On the topic of the `ARGS` and `User undefined has joined the connection` -...
I have a few nitpicks, but the overall approach looks pretty good to me. @mike-jumper thoughts?
> @jmuehlner Any further changes that need to be made on this one? Nope, looks reasonable to me.
Are there still issues with this PR? It looks pretty straightforward, and the issue appears to be still valid as well.