guacamole-server icon indicating copy to clipboard operation
guacamole-server copied to clipboard

Published 20 hours ago • verified publisher icon apache

GUACAMOLE-1293: Add support for notifying that a user has joined an existing connection.

Open necouchman opened this issue 3 years ago • 3 comments

This pull request adds support for notifying the connection owner that another user has joined their connection. This is broken up into three commits - the first adds the underlying support for the "msg" instruction and updates the protocol accordingly, the second adds support for the "name" handshake instruction, allowing guacd to have a human-readable user name, and the third the actual support for sending the notification.

I'm sure it needs some work and clean-up, and there may be better approaches, but I took a shot :-D.

necouchman avatar Dec 26 '21 00:12 necouchman

@jmuehlner I think this one is also ready for another review.

necouchman avatar Jul 23 '22 01:07 necouchman

Awesome! Having a look.

jmuehlner avatar Jul 25 '22 17:07 jmuehlner

As with https://github.com/apache/guacamole-client/pull/668, I have a few minor nitpicks, but this overall looks pretty good to me.

I'm curious if @mike-jumper has any thoughts.

jmuehlner avatar Jul 25 '22 17:07 jmuehlner

Thanks @mike-jumper - I think I've addressed everything, and have confirmed it compiles. Need to update some of the client-side code, as well.

necouchman avatar Nov 08 '22 14:11 necouchman