Joshua Root

@vstinner What is still needed for this to be ready to merge?

Looks similar to the issues fixed by #2383 and #2387. Those changes are applied in MacPorts, which has successful builds on all tested OS versions: https://ports.macports.org/port/libjxl/details/

This fixes the issue for me: ```diff --- lib/jxl_threads.cmake.orig 2023-12-23 01:33:41 +++ lib/jxl_threads.cmake 2024-01-03 05:10:32 @@ -13,6 +13,7 @@ set_property(TARGET jxl_threads PROPERTY POSITION_INDEPENDENT_CODE ON) target_include_directories(jxl_threads + BEFORE PRIVATE "${PROJECT_SOURCE_DIR}" PUBLIC...

``` /opt/local/var/macports/build/_Users_runner_work_macports-ports_macports-ports_ports_java_openjdk8/openjdk8/work/jdk8u-jdk8u402-ga/hotspot/src/os_cpu/bsd_zero/vm/os_bsd_zero.cpp:384:8: error: conflicting types for '_Copy_conjoint_jshorts_atomic' void _Copy_conjoint_jshorts_atomic(const jshort* from, jshort* to, size_t count) { ^ /opt/local/var/macports/build/_Users_runner_work_macports-ports_macports-ports_ports_java_openjdk8/openjdk8/work/jdk8u-jdk8u402-ga/hotspot/src/share/vm/utilities/copy.hpp:44:8: note: previous declaration is here void _Copy_conjoint_jshorts_atomic(jshort* from, jshort* to, size_t count);...

At a glance, the const qualifiers are being used on things that shouldn't be written to and so should probably do no harm. I don't know why that change would...

If we're going to do anything about this, I would want to do it in base, maybe by running `file normalize` on all paths read from macports.conf. Anything that checks...

Buildbot will never have an older version active. If this needs to override the installed version with the version being built, setting `PYTHONPATH` to its location under `${worksrcpath}` would be...

It looks like the duplicate dep is due to calling crossbinutils.setup more than once in most of the subports. It also looks like the portgroup is not designed to support...

It would be better to fix the portgroup to not overwrite the `name` if already set. Then set `name` up front and put the first crossbinutils.setup call inside the `...

With the portgroup change, all that's needed is this part of my earlier comment: > set name up front and put the first crossbinutils.setup call inside the {${subport} eq ${name}}...