Joshua Root

Results 64 comments of Joshua Root

Individual portions appear to be under one of the licenses, different for each portion, but with no option to use anything different for that portion. So the overall license for...

Just a note that if you use zero timestamps, you will need to use `strict_timestamps=False` with zipfile to avoid errors. It might not be a bad idea to do that...

Ah, interesting. I found that the `ZipInfo.from_file` call still fails when the file has a pre-1980 mtime. (Long story involving a not-quite-pax compatible unarchiver and the tarfile module.)

I ended up doing this to avoid the problem. ```diff --- flit_core/wheel.py.orig 2021-11-15 01:34:30.000000000 +1100 +++ flit_core/wheel.py 2021-11-21 17:00:14.000000000 +1100 @@ -7,6 +7,7 @@ import os import os.path as osp...

Oh, well that's unfortunate, since it builds and runs fine on 10.7 apart from this (autotools build, not Xcode of course).

> @kencu This is by the way genuinely Rosetta-specific problem (on 10.6 PPC the triple is set correctly). It's not really even wrong. The machine you're building on really is...

@vstinner Is there something that is defined iff Python itself is being built? Other users of the headers don't necessarily need `static_assert`, so it would be nice to avoid defining...

> In practice, which platform/libc/compiler is impacted by this change? I only know of the ones mentioned in the comment, i.e. FreeBSD

From our (MacPorts) point of view, we're going to be adding these workarounds downstream anyway for a long time to come, so we might as well send them upstream.

@mojca Any reason not to merge this?