Jan Midtgaard
Jan Midtgaard
Closing as this is addressed in #245
This is great indeed, thanks @n-osborne! :smiley: I second @vch9's suggestion of also adding the bytes combinators to QCheck2 to keep the two versions aligned. I would also appreciate it...
Thanks @n-osborne! :pray: I'm sorry that this drifted into a design PR as this takes extra time to get right. To summarize, with this PR we arrive at the below...
Thanks again for your patience on this issue. I think it is shaping up nicely! Meanwhile the shrinker in `QCheck.string_printable` has been fixed and merged, meaning this PR now contains...
Thanks for the `printable` `bytes` shrinker fix! Taking another pass of it I noticed that the CHANGELOG entries are off - and there is also an unintentional reversion of #249...
I've committed a few more changes I proposed in https://github.com/c-cube/qcheck/pull/245#issuecomment-1162975158 For reference, below follows a summary of the resulting `bytes` and `string` combinator interfaces. Ignoring the `(* to-be-deprecated: *)` sections,...
@n-osborne can I ask you to take a quick look at the last commits - just one at a time - to see if they make sense - before we...
Hereby merged - thanks! :smiley:
Here's another one (which might be harder though): - https://github.com/ocaml/ocaml/issues/10990
Another one (for `.mli` files): - https://github.com/ocaml/ocaml/issues/12055