Jan Midtgaard
Jan Midtgaard
(also paging @sir4ur0n which I couldn't add as a reviewer)
Note: there are two options for the verbose output: either use `run_tests` with the `~verbose:true` option: ``` utop # QCheck_base_runner.run_tests;; - : ?handler:QCheck_base_runner.handler_gen -> ?colors:bool -> ?verbose:bool -> ?long:bool ->...
I'll be happy to help with this (once I clear off a few other things at my end) and your name suggestions make good sense. I'm reluctant to go with...
Thanks for this! :pray: In QCheck(1) there's: ```ocaml val set_shrink : 'a Shrink.t -> 'a arbitrary -> 'a arbitrary ``` meaning you can achieve something like this with `set_shrink Shrink.nil...
Looks good! Three minor/bike-shed'dy things: - ~~We should probably add a small test of `set_shrink` too?~~ - Regarding documentation a reader could misunderstand this comment to be side-effecting (if they...
Sorry, I take back the suggestion of adding a test of `set_shrink`, since you're already using it to implement `without_shrinker`/`no_shrink` and hence testing it as part of that... (I blame...
Looks good to me, thanks!
I agree with @c-cube. The QCheck2 shrinker code is still relatively immature. Also: as I tried to illustrate in the shrink logs #172 QCheck2 sometimes has shrinker issues due to...
> @jmid Have you tried either of `pringo` or `splittable_random` as a splittable RNG library? I think I tried them briefly at some point. My interest was in how splitting...
It is nice to align the `.ml` and `.mli` for consistency. However, as far as I can tell (see examples and discussion in #162) this still means that the parameter...