Jan Midtgaard

Results 395 comments of Jan Midtgaard

Here's a couple of half-baked ideas to achieve something like that: - By raising a suitable exception upon meeting the criteria and wrapping a `try`-`catch` of around `Test.check_*` to catch...

> `[@@deriving qcheck]` and `[@@deriving qcheck2]`. Looks like good names to me!

I can certainly follow you. In a sense, the folklore of "the tester needs to be mindful of testing corner cases" translates to "the PBT tester needs to be mindful...

I looked at this a bit to create a small repro: repro/dune: ``` (test (name test) (libraries qcheck-core qcheck-core.runner)) ``` repro/test.ml: ```ocaml let test = QCheck2.Test.make ~name:"name" QCheck2.Gen.int (fun _...

Closing as this should be fixed in ocaml/dune#5528 released with dune 3.5.0

Thanks for taking a stab at this! Overall this LGTM 😀 I spotted a few occurrences of `small_nat` in the interface and in the implementation. It would make sense to...

> > Finally, there's the "optional parameters that aren't so optional" that you didn't intend to address in this PR: We should do so as part of rewamping the QCheck2...

> Regarding `make_primitive` I think we could change to: > ``` > val make_primitive : ?shrink : ('a -> 'a Seq.t) -> (Random.State.t -> 'a) -> 'a t > ```...

Hm. I'm starting to realize that this has opened a can of worms and wonder if the design is going in the direction we intend it to... In a sense,...

I think it is a good idea to add a sub-module of backtracking (option-valued) generators similar to https://github.com/gasche/random-generator/. For both - eff-tester https://github.com/jmid/efftester and - wasm-prop-tester https://github.com/jmid/wasm-prop-tester we ended up...