Jade Mattsson

Results 75 comments of Jade Mattsson

Okay, I've submitted PR #3652 - please take a look. It should address: - CR/LF translation - Inability to use `uart.on('data')` on the console uart - No way to determine...

While I like not having errors thrown needlessly, I don't see how we could find out the correct return value in the reject case?

We currently return the wakeup cause from this function, but I guess we could use `ESP_SLEEP_WAKEUP_UNDEFINED` for the sleep-rejected case? Not sure whether that's cleaner that the current behaviour though?

`EXCVADDR: 0x00000003` That's effectively a null pointer dereference crash. Probably into the second element of a struct with a 32bit first element. If you use `idf.py monitor` you'll probably get...

Ah, one other review comment - the documentation needs to be linked in `mkdocs.yml` too :)