Joseph Marrero Corchado

Results 49 comments of Joseph Marrero Corchado

I used: https://github.com/ueberdosis/alldocs.app which is hosted on: https://alldocs.app/ to generate this https://github.com/coreos/rpm-ostree/pull/3272/files#diff-91cab257955ce52024a4473c290e8df59d542e46c8e58f16d2fce925c345baca markdown from the docbook and included it on my PR as a starting point. Maybe we can use...

I agree with moving now to `dracut.conf.d` and moving away from `initramfs-args`. If dracut already provides us a way of doing this, I don't see why we should duplicate the...

> Is this going to need to be run on different architectures? or just on x86_64? This is part of the effort for Openshift 4.12, I don't see why it...

> This is looking good to me so far! > > If you haven't yet tried this; one problem today is that no CI covers `push-container`. I've been testing it...

Testing I found that somehow I am dropping `coreos-assembler.image-genver` & `delayed-meta-merge` when writing the JSON. they are part of the schema so I am not sure why yet. ``` ➜...

> Testing I found that somehow I am dropping `coreos-assembler.image-genver` & `delayed-meta-merge` when writing the JSON. they are part of the schema so I am not sure why yet. >...

> Well the issue I hit was the dropping of: ``` coreos-assembler.image-genver ``` That is used when we generate a new build on: ``` src/cosalib/builds.py 131: genver_key = 'coreos-assembler.image-genver' ```...

> ``` > diff --git a/src/cosalib/builds.py b/src/cosalib/builds.py > index 4a378d7ba..4e8ebe41c 100644 > --- a/src/cosalib/builds.py > +++ b/src/cosalib/builds.py > @@ -136,7 +136,7 @@ class Builds: # pragma: nocover > with open(metapath)...

> Thanks so much for all your work on this! thank you for all the help!

I think the intent is to allow the user to set the number of deployments to keep. So if it's set to 1, you still would temporary balloon to 2...