Joseph Marrero Corchado
Joseph Marrero Corchado
Renamed, I think we can influence how it looks with the `--name` we pass to `cosa create-legacy-oscontainer` and when we push it. We can discuss it on the PR doing...
Playing with the `upload-container-manifest` not doing the upload while creating the container might be a bit tricky. The meta.json currently has oscontainer in a seperate entry from the artifacts. ```...
> Hmm I think https://github.com/openshift/doozer _might_ rely on that...why can't we write the remote registry here still? with: https://github.com/coreos/coreos-assembler/pull/3111/commits/22d1a813e17593e81271071c236f6b516846866a it can. But without that, the --name could be a url.
Tested that: ``` cosa push-container-manifest --repo quay.io/MYREPO/MYIMG --tag oscontainer --artifact=oscontainer --metajsonname=oscontainer ``` Now works with the file and meta.json updated generated by: ``` cosa create-legacy-oscontainer ``` The meta.json entry looks...
Upgrades test failing with ``` Error: failed to parse build: json: unknown field "digest" [2348](https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/coreos_coreos-assembler/3111/pull-ci-coreos-coreos-assembler-main-rhcos/1578423504221507584#1:build-log.txt%3A2348) 2022-10-07T17:35:24Z cli: failed to parse build: json: unknown field "digest" [2349](https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/coreos_coreos-assembler/3111/pull-ci-coreos-coreos-assembler-main-rhcos/1578423504221507584#1:build-log.txt%3A2349) {"component":"entrypoint","error":"wrapped process failed: exit...
I don't see `push-container-manifest` in https://github.com/coreos/coreos-assembler/commits/rhcos-4.8 so that will be required to be backported too. @dustymabe you had any other plan? like trying to build old versions with the latest...
> Is the update to go modules (vendoring) required in this PR? Can we split it to a separate PR? Since I am adding something to new to the schema...
> > > Is the update to go modules (vendoring) required in this PR? Can we split it to a separate PR? > > > > > > Since I...
> Only skimming the conversation here, I'd just note that while I'm all in favor of renaming the CLI etc. to call the old container "deprecated" in main/latest/4.12, I don't...