jmachowinski

Compilefix / pkgconfig

2

Hey, these commits add a package config file, fixes the detection of the libs on ubuntu 14.04 and removes the need to set the defines manually. If you don't like...

Corrupted JPEG Stream

41

**Describe the bug** We are experiencing a rather strange bug with the color stream of the kinect. On an AMD EPYC 7302 machine, the color stream is corrupted. This is...

Potential Bug - Profile Performance of using Sleep in the frame loop and its effects on the longterm frame stability

5

Hi, I'm confused about some parts of the code : https://github.com/microsoft/Azure_Kinect_ROS_Driver/blob/01b5a781f499b32d2babed97a534537b954e0d69/src/k4a_ros_device.cpp#L1181 Why is this done here ? AFAIK there is already the spin in the main thread. Also I do...

Driver hangs forever if initial open failed

3

**Describe the bug** If at the end of constructor of K4AROSDevice k4a_device_ is still nullptr, a ROS_ERROR is outputted, but the node is not shut down. This leads to a...

Executer regression fix

1

Fixes https://github.com/ros2/rclcpp/issues/2508

fix(StaticSingleThreadedExecutor): Fixed regression in spin()

5

Fixes https://github.com/ros2/rclcpp/issues/2470

This was introduced in #2142 https://github.com/ros2/rclcpp/blob/3d58f0fb703d86461c2ab2fb39cd2640dc26e219/rclcpp/src/rclcpp/executor.cpp#L383 This condition make the executor active spin until the time is over if used in spin_all. I guess ```c++ if (!wait_result_.has_value() || !exhaustive) {...

test: Added more benchmarks for the executor

6

Added additional benchmarks for the executors @mjcarroll These are the benchmarks you requested in #2142.

StaticSingleThreadedExecutor uses spin_once in spin

1

This change seems to have been made in https://github.com/ros2/rclcpp/pull/2142 https://github.com/ros2/rclcpp/blob/c5bc4b65284c71a86fc1758cc7eeb22204aa2bdd/rclcpp/src/rclcpp/executors/static_single_threaded_executor.cpp#L41C1-L43C4 ```c++ while (rclcpp::ok(this->context_) && spinning.load()) { this->spin_once_impl(std::chrono::nanoseconds(-1)); } ``` I guess it should be ```c++ while (rclcpp::ok(this->context_) && spinning.load()) {...

rclcpp::experimental::TimersManager most likely broken for mixed timers

1

## Bug report **Required Info:** - Client library (if applicable): rclcpp #### Additional information I went through the code of rclcpp::experimental::TimersManager , as I wanted to use it for my...