Joshua MacDonald
Joshua MacDonald
Suggestion from Kent: please try to minimize diffs by keeping to one sentence per line of markdown.
@kalyanaj now that I've read this PR in detail, I agree with @tigrannajaryan's suggestion. This PR is difficult to review because of all the editorial changes, which I also appreciate....
I have copied the bulk of this PR into https://github.com/open-telemetry/opentelemetry-specification/pull/4166.
We should merge this, just need approvals. The language in this PR is already incorporated into the spec PRs, no reason not to merge.
I wish to certify that this is 99% editorial change and the rest is to correct a problem discovered during early implementation. We believe there are no other implementations of...
The sampling SIG is pursuing a new "optional" sampler API that will improve the performance of this feature. https://github.com/open-telemetry/opentelemetry-specification/pull/4294
This has been approved for 2 weeks. Can it merge?
> Can I ask you to fix up the merge conflicts please? Of course! I fix the conflicts after every release, but this has been sitting for two release cycles...
@songy23 Thank you. I appreciate your help. The linter changed while this PR was open,. I want to point out that this PR was approved and green following commit [f735180](https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/34733/commits/f735180df61fd28336a7aceaec323e6a1e68515f)...
I will present this RFC in the next two Collector SIG meetings 1/7/2025 (APAC/PT) and 1/15/2025 (NA).