James Lucktaylor

Results 10 comments of James Lucktaylor

We had a crash on my server today, running Factorio 1.0.0, that seems similar to this one, so I'm appending here rather than create a new issue. I took a...

I recommend taking a look at the new `graftorio2` fork [here](https://github.com/remijouannet/graftorio2) and recreating/adapting this PR as necessary. 😃

@westernwontons I have opened a PR that adds this option: #1024

From [the pre-commit docs here](https://pre-commit.com/index.html#golang): > The hook repository must contain go source code. It will be installed via go `install ./...`. > pre-commit will create an isolated `GOPATH` for...

I was just bitten by this as well. Would like to be able to discover the paths of git repositories, whilst still honouring their respective `.gitignore` files, please. 🙏

I have found that this seems to be working the way we'd want it to: ```typescript async function main() { const logger = createRootLogger({ format: winston.format.combine(IgnoreK8sHCProbe(), getRootLogger().format), }); ``` This...

Thanks for the assist @benjdlambert 🙂 ```typescript const wlo: WinstonLoggerOptions = { format: format.combine(IgnoreK8sHCProbe(), getRootLogger().format), level: getRootLogger().level, transports: getRootLogger().transports, }; const logger = WinstonLogger.create(wlo); console.log('hello'); logger.info('hello'); ``` If I create...

> @jlucktay do you think we can close this issue if you're using the new one? It's most likely that we will look to deprecate some of the older methods...

No worries, thanks @benjdlambert, but I can't give just `format` by itself to `WinstonLogger.create` because it doesn't meet the `WinstonLoggerOptions` interface. This is the full error: ``` Argument of type...

Having those properties be optional with some defaults to fall back on sounds like it would resolve this, yes. 👍