graftorio icon indicating copy to clipboard operation
graftorio copied to clipboard

Massive rework for .18

Open TimVroom opened this issue 4 years ago • 6 comments

Reworked to be up to coding standards for 0.18 / 1.0 Currently incorrect/now working: train schedules/trips.

Added a lot of stats to the exporting (force/robots etc) Added power for exporting Added mod/game info to the export.

TimVroom avatar Aug 11 '20 21:08 TimVroom

@TimVroom Your rework version works very well (at least in my env). However this original mod owners seems not to be active on GitHub for a long time, so I think this pull request may not to be merged. Do you have a thought to release your reworked version as like graftorio2?

P.S. I found some typo in README.md and mod output data.

SnO2WMaN avatar Aug 16 '20 15:08 SnO2WMaN

Also tested it quickly and all seems to work with 1.0. But I do not want to enable the whole time, as this would need all users to download it manually. So can't test it currently with multiple players online at the moment.

attrib avatar Aug 23 '20 17:08 attrib

The mod does seem to work with v1.0 but we're getting this issue occasionally when saving the map:

2427.751 Error ParallelScenarioSaver.cpp:114: Saving scenario failed: The mod graftorio (1.0.25) caused a non-recoverable error.
Please report this error to the mod author.

Error while running event graftorio::on_save()
LuaCustomTable cannot be serialized.
2427.761 Error Util.cpp:83: Attempting to create notice box in headless mode. Message: 'Cannot save map: The mod graftorio (1.0.25) caused a non-recoverable error.
Please report this error to the mod author.

Error while running event graftorio::on_save()
LuaCustomTable cannot be serialized.'

wbourne0 avatar Sep 16 '20 00:09 wbourne0

@TimVroom do these fix the issue that I pointed out?

wbourne0 avatar Dec 02 '20 01:12 wbourne0

Also tested it quickly and all seems to work with 1.0. But I do not want to enable the whole time, as this would need all users to download it manually. So can't test it currently with multiple players online at the moment.

Yes it seems to work okay ish on 1.0. There is currently a setting that is enabled by default to only save on the server, so that saves a little bit of ups for the users.

@TimVroom do these fix the issue that I pointed out?

It should be yes, be aware that it might be a bit slower on bigger bases.

TimVroom avatar Dec 03 '20 22:12 TimVroom

I recommend taking a look at the new graftorio2 fork here and recreating/adapting this PR as necessary. 😃

jlucktay avatar Dec 18 '20 11:12 jlucktay