Jérémy Lourenço

Results 6 comments of Jérémy Lourenço
trafficstars

If the aim is to keep supporting Node v0 which is end-of-life since 2016, then yes it is a breaking change. However, such an aim is, in my opinion, counter-productive....

> Hi, why not update to busboy atleast version ^1.6. 0? The aim of this PR is to remove `dicer` from the dependencies, which is achieved by upgrading to at...

I have now enforced the node engine to be `>= 6.0.0`.

Hey @LinusU, > Unfortunately, I also see it as a big problem to release this as 1.x since it would break compatibility with older Node.js versions. I've tested again compatibility...

Hey @Jeffail, it'd be great to have your thoughts on this PR. Thanks!

Sure @Jeffail , that makes sense. Let me revisit this PR not to impact the path of `Search`. In the meantime, I've opened #115 to make `Search` faster when using...