gabs icon indicating copy to clipboard operation
gabs copied to clipboard

Published 20 hours ago • verified publisher icon Jeffail

Support nested array wildcard deletion

Open jlourenc opened this issue 4 years ago • 3 comments

This PR supersedes #95 by supporting wildcard deletes at all levels in a Container's hierarchy.

searchStrict has been refactored and renamed into searchPaths to provide return parameters that are both useful for Search and Delete methods.

The notion of path with its associated types path and paths has been introduced to reflect the multiplicity of paths that wildcards introduce.

jlourenc avatar Oct 17 '21 21:10 jlourenc

Hey @Jeffail, it'd be great to have your thoughts on this PR. Thanks!

jlourenc avatar Nov 04 '21 21:11 jlourenc

Hey @jlourenc, I'll need to put some proper time aside to understand fully what's going on here but we'd also need to leave Search unchanged, as this change would add unused allocations to a potentially hot path.

Jeffail avatar Nov 05 '21 08:11 Jeffail

Sure @Jeffail , that makes sense. Let me revisit this PR not to impact the path of Search.

In the meantime, I've opened #115 to make Search faster when using wildcards.

jlourenc avatar Nov 05 '21 23:11 jlourenc