Jose Luis Duran
Jose Luis Duran
This is really nice! Congratulations! My two future suggestions: 1. As `freebsd-update` is about to go, so is its `IDS`. It would be nice to mimic its functionality by extending...
In the commit message, `sysctrl.conf(5)` -> `sysctl.conf(5)`.
> Do I need to close this and open a new/clean pull request? No worries! It is better to keep it on this same pull request. It is likely that...
@emaste: This is now upstreamed (configure.ac). Do you want to wait until 10.1 or cherry-pick openssh/openssh-portable@67a8bf4e4057597170bfa923fe2ce5bf90c43974?
> The patch has been accepted upstream. What does `invalid` label mean? It means I was in the middle of removing the labels :upside_down_face: and testing.
Documentation! Great, thank you! There are a couple examples under tests/examples that can be pointed out in this man page.
Please address the issues reported by: ``` mandoc -T lint tests/atf_python/atf-python.3 ```
Thank you. This is very nice to have. Should a reference to this man page be in `atf(7)`? LGTM.
> @jlduran > > It has been a week since your approval. > > If there is no one who wants to review, maybe we could merge the commits now?...
I believe this change stems from: https://github.com/torvalds/linux/commit/aeb74914ef0e6746f15b11c0399048de9c5c05b8 Shouldn't the proper fix be? ```diff --- a/sys/dev/ata/ata-pci.h +++ b/sys/dev/ata/ata-pci.h @@ -430,8 +430,8 @@ struct ata_pci_controller { #define ATA_HT1000_S1 0x024b1166 #define ATA_HT1000_S2 0x024a1166...