Jose Luis Duran
Jose Luis Duran
Comparing this file with [Darwin's], the fix still seems ok. [Darwin's]: https://github.com/apple-oss-distributions/file_cmds/blob/file_cmds-430.100.5/install/xinstall.c
> Knowing the directory that failed is much more important, I think. Yes, I was essentially pondering between using `dirname(tempfile)` (this patch) or `to_name`, to match the output produced in...
Sorry, I changed my mind. I would prefer to use `to_name`, and match the output of the aforementioned operating systems: With `dirname(tempfile)`: ```console % touch testf % install testf nonexistent/...
No problem, Warner said that just printing the directory name is more important. I was just trying to find an edge case. At least having a test case clearly expresses...
It is fine as is. I'm bike-shedding on this pull request, even thinking about appending a slash to indicate it is a directory.
> [!NOTE] > Note to self: > Perhaps a better approach is to disable this error globally: > https://github.com/freebsd/freebsd-ports/blob/27752cbbf356a57026053522139dcf63a770d2ac/devel/arcanist-lib/files/patch-src_error_PhutilErrorHandler.php
Reading the comment in: https://github.com/github/task-lists-element/blob/78fff629fcb57cca1841d0899f48581f05c6788b/src/sortable.ts#L140 It appears that this behavior is explicit.
Related to #1180?
> * There is no exit code, and the jail is empty (with only pkg repo configured) @ocochard Maybe: ```diff --- a/src/share/poudriere/jail.sh +++ b/src/share/poudriere/jail.sh @@ -927,7 +927,8 @@ FreeBSD: {...
No problem, I'll also add the patch suggested in https://github.com/freebsd/poudriere/issues/1242#issuecomment-3377559205 as part of the series.