freebsd-src icon indicating copy to clipboard operation
freebsd-src copied to clipboard

atf-python(3): add atf-python introduction for atf test library.

Open Rin0913 opened this issue 8 months ago • 14 comments

I wish I could write a good documentation, but what I have done is not so good.

Please provide some advises if possible.

@ihoro @AlexanderChernikov

Rin0913 avatar Apr 06 '25 19:04 Rin0913

Documentation! Great, thank you!

There are a couple examples under tests/examples that can be pointed out in this man page.

jlduran avatar Apr 08 '25 14:04 jlduran

@jlduran Added!

Rin0913 avatar Apr 08 '25 21:04 Rin0913

@lwhsu Please assign reviewers, thanks.

Rin0913 avatar Apr 12 '25 11:04 Rin0913

Please address the issues reported by:

mandoc -T lint tests/atf_python/atf-python.3

jlduran avatar Apr 12 '25 18:04 jlduran

@jlduran Done.

Rin0913 avatar Apr 13 '25 08:04 Rin0913

Thank you. This is very nice to have. Should a reference to this man page be in atf(7)? LGTM.

jlduran avatar Apr 14 '25 03:04 jlduran

Thank you. This is very nice to have. Should a reference to this man page be in atf(7)? LGTM.

A reference has been added to atf(7).

Rin0913 avatar Apr 14 '25 04:04 Rin0913

I have no relation to atf-python implementation to help in cases if something is missing or a special moment should be mentioned. Nevertheless, the foundation has been laid and future improvements have the baseline. Thank you for the improvement!

ihoro avatar Apr 17 '25 18:04 ihoro

@jlduran

It has been a week since your approval.

If there is no one who wants to review, maybe we could merge the commits now?

Thank you very much.

Rin0913 avatar Apr 20 '25 17:04 Rin0913

@jlduran

It has been a week since your approval.

If there is no one who wants to review, maybe we could merge the commits now?

It has also been reviewed by @ihoro, but I should not commit without explicit approval. cc/ @bsdimp @emaste

Thank you very much.

jlduran avatar Apr 20 '25 18:04 jlduran

@lwhsu Done.

Rin0913 avatar Apr 24 '25 07:04 Rin0913

i would like to land this but i'm not clear what is still required. it looks like tests/atf_python/atf-python.3 was already committed, is it only the Xr in atf.7 which is still pending?

llfw avatar May 17 '25 00:05 llfw

Thank you for taking the time to contribute to FreeBSD! All issues resolved.

github-actions[bot] avatar Nov 16 '25 20:11 github-actions[bot]

@concussious as you like it :)

Rin0913 avatar Nov 16 '25 20:11 Rin0913