Jason Kirk

Hey @jamesbraza, just as an FYI I put in a PEP 541 request about this same name a few months ago (https://github.com/pypi/support/issues/4314) for my team's project, also called Aviary. We've...

> Should those `_SCALER` variables be defaulted to 1.0? We should have the scaler variables follow the same pattern as everything else, so that may be a default of 0...

This may be completely or partially addressed through many improvements to conversion utility. More investigation needed to check if any edge cases are currently missing

A "universal" breguet range equation that can handle any aircraft may not be possible because it would need a generic propulsive efficiency which is difficult to get from some engine...

This has been partially fixed. Variables that were never specified by the user or present in the input file no longer show up in the json file. Variable values that...

> I think the actual shooting example file was mistakenly omitted from this PR. > > EDIT - Reread the description. I guess we are supposed to modify this after...

I propose that we just let the user directly provide which variable is the "fallout" var (e.g. mass, range). Maybe we need to define a new enum in the short...

> Related to this, `mission_inputs` and `mission_outputs` methods are also not called when using a custom engine builder. This one is a little tricky because I have to do some...

We may want to enforce this via a constraint so the design fails/is infeasible when this happens (we can call a warning that specifies that as one of the reasons...

There are major discrepancies between the wing and tail mass computations that need to be resolved before I'll approve merge. Tests could use some additional cases, there are currently no...