Jason Kirk

Results 68 comments of Jason Kirk

#508 adds docstrings to most functions & classes. Important docstrings (accessible through api.py) need complete docstrings with attributes, methods, etc. fully documented. Automated docs page that pulls docstrings from everything...

I would like to see defaulting of legacy code variable names to `None` so you don't have to explicitly specify that

This needs additional review - setting metadata explicitly is desired for models where the metadata has been extended

This suggestion needs to be re-visited for the current Aviary version - do we still desire this capability?

Numpy 2.0 is on our radar and we'd like to support, but yeah simupy is holding that back. We have plans to address it, probably a month or two out...

Numpy 2.0 theoretically should now work with Aviary now that Simupy was pulled. We need to test that an environment created with numpy2 will run all tests, and the version...

From our latest discussions on this topic, the current proposal is to move `Mission.Design` values to `Aircraft.Design` where it makes sense, and remove the "Summary" subcategory so things like `Mission.Summary.GROSS_MASS`...

Hi Peter, thanks for the feedback! If you can point me to some of the specific variables that you found to have unhelpful descriptions, I can try and update those....

Phase name should not be used for any logic in Aviary. Instead, at most we should be using phase builder types or ODE types to determine what the phase is...

We can try checking if a value in driver options exists before setting the default. Is there a specific use case where you need to define driver options _before_ calling...