Aviary icon indicating copy to clipboard operation
Aviary copied to clipboard

Standardize component defaults across Aviary

Open jkirk5 opened this issue 1 year ago • 3 comments

Desired capability or behavior.

With many of our components, default values for inputs/outputs are provided that come from a variety of sources - maybe there were old GASP defaults, generally reasonable values, or values that match a particular aircraft model. This is not desired for a variety of reasons.

  • These defaults can differ from what is specified in the variable metadata, which confuses which value is the "true" default
  • It can make it difficult to realize that a value was never set/specified
  • It perpetuates bad coding practices, where data should be kept separate from code among other things. A standard default (such as 0 or 1) should be enforced for all component inputs/outputs. Options may want similar treatment but may require additional thought before implementing.

Is your feature request related to a problem? Please describe.

No response

Associated Bug Report

No response

jkirk5 avatar Nov 13 '24 19:11 jkirk5

What about options in components?

xjjiang avatar Dec 03 '24 16:12 xjjiang

Should those _SCALER variables be defaulted to 1.0?

xjjiang avatar Dec 03 '24 16:12 xjjiang

Should those _SCALER variables be defaulted to 1.0?

We should have the scaler variables follow the same pattern as everything else, so that may be a default of 0 as well. In the metadata those should have a default of 1.0, but within components they would be 0

jkirk5 avatar Dec 09 '24 16:12 jkirk5