hapi-fhir icon indicating copy to clipboard operation
hapi-fhir copied to clipboard

Fixing locale

Open jkiddo opened this issue 6 months ago • 3 comments

This pull request updates the TimeoutManagerTest to improve locale-awareness in its logging tests. The most important changes include importing locale-related classes and modifying the test logic to dynamically handle the decimal separator based on the system's default locale.

Locale-awareness improvements:

  • hapi-fhir-base/src/test/java/ca/uhn/fhir/util/TimeoutManagerTest.java: Added imports for DecimalFormatSymbols and Locale to support locale-specific formatting.
  • checkTimeout_warningThreadholdHit_warningLogged: Updated the test to dynamically determine the decimal separator using DecimalFormatSymbols and the system's default locale. This ensures the test output is consistent with locale-specific formatting.

jkiddo avatar May 25 '25 11:05 jkiddo

[spotless]: Formatting check succeeded!

robogary avatar May 25 '25 11:05 robogary

@fil512 based on git history I'd say one is in your direction :)

jkiddo avatar May 25 '25 11:05 jkiddo

[spotless]: Formatting check succeeded!

robogary avatar May 26 '25 07:05 robogary

Formatting check succeeded!

robogary avatar Jun 26 '25 13:06 robogary