Jeshurun Hembd

Results 120 comments of Jeshurun Hembd

Hi @javagl, I ran into similar issues while trying to trace through how we generate our depth buffers. I incorporated several of your ideas in https://github.com/CesiumGS/cesium/pull/12188. If https://github.com/CesiumGS/cesium/pull/12188 makes sense...

Hi @MingFanZhu, sorry for the delayed follow-up. I think this looks good overall, I just have 2 questions: 1. Can you explain why this change improves the performance? 2. Do...

@xtassin thanks for the Sandcastle! I agree that this behavior is not what we want. However, I re-labeled the issue as an enhancement rather than a bug, since the desired...

Thanks @ggetz, the code change makes sense. Some of the tests are fixed, but several others are still failing on my machine. ```bash 1) creates environment map and spherical harmonics...

Hi @ggetz, this looks like another improvement. I still have 3 tests failing: ```bash 1) produces radiance values with mainly blue direct light Scene/DynamicEnvironmentMapManager render tests with static lighting at...

Another community member requested this: https://community.cesium.com/t/how-should-cesium-attach-the-map-layer-to-the-3dtiles/34875/3

Requested again at https://community.cesium.com/t/xyz-tile-layer-2d-over-photorealistic-3d-tiles-in-recent-version-like-1-123/36456/1

The `czm_globeDepthTexture` already includes both the terrain and 3D Tiles surfaces. While a user _could_ sample this texture in the `CustomShader`, this would be clumsy and slow. The `customShader` supplied...

As a first step to generate an end-to-end test, I plan to write a custom shader using a brute-force method: 1. Set `VoxelPrimitive.depthTest === false` to allow raymarching beyond the...

@ggetz, - My initial guess is that `czm_globeDepthTexture` will have adequate precision/accuracy at relevant camera positions. It loses precision in the distance, but most users will be zoomed in to...