Jeshurun Hembd

Results 120 comments of Jeshurun Hembd

Here's another pattern that appears frequently in our code: ```javascript for (const key in myObject) { if (myObject.hasOwnProperty(key)) { const value = myObject[key]; // do something with value } }...

A few more old polyfills that could be replaced: - [requestAnimationFrame](https://cesium.com/learn/cesiumjs/ref-doc/global.html#requestAnimationFrame): replace with the [Web API method](https://developer.mozilla.org/en-US/docs/Web/API/window/requestAnimationFrame) - [cancelAnimationFrame](https://cesium.com/learn/cesiumjs/ref-doc/global.html#cancelAnimationFrame): replace with the [Web API method](https://developer.mozilla.org/en-US/docs/Web/API/Window/cancelAnimationFrame) - [combine](https://cesium.com/learn/cesiumjs/ref-doc/global.html#combine): replace with [Object.assign](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/assign)....

I think deprecating geobuf makes sense. It doesn't seem to work for larger files--at least on my machine, json2geobuf runs out of memory with a 4.5 GB input. Based on...

I captured the warnings in a file to evaluate. There are 1234 warnings, and 1230 of them are "Failed to find parent of doclet...". I think this is a [known...

A significant part of what this issue describes has been implemented in #10520 and #10683. I opened two new issues, #10799 and #10800, to better define the remaining features that...

Resolved in https://github.com/CesiumGS/cesium/pull/11640

When prototyping in Sandcastle, it is easy to lose a lot of work if the browser crashes, because the browser URL doesn't update. My current practice is to manually save...

Also reported in https://github.com/CesiumGS/cesium/issues/10974

The problem behavior will be in the `main` branch after https://github.com/CesiumGS/cesium/pull/11828 is merged

@ggetz after https://github.com/CesiumGS/cesium/pull/11875 I observed a similar problem on Windows. I fixed a sample indexing problem at the edges of the volume, in https://github.com/CesiumGS/cesium/pull/11909/commits/4c6e7ea0cb176b73ddd8570c8e97b68bd07f26d2 (part of https://github.com/CesiumGS/cesium/pull/11909). Can you please...