Jeshurun Hembd

Results 120 comments of Jeshurun Hembd

> A bigger issue for our IBL is the way we handle the diffuse component. The BRDF and Fresnel terms for the diffuse component in the glTF Sample Viewer are...

For reference, this paper questions the validity of the "Schlick-Smith Approximation", suggesting that it overestimates the masking effect (which could potentially make our images too dim): https://jcgt.org/published/0003/02/03/paper.pdf See Figure 12...

Here is a quick comparison of the two geometric self-shadowing functions. The effect is subtle, and limited to direct lighting. We use a different code path for IBL. Current Cesium...

Also reported [on the forum](https://community.cesium.com/t/there-seems-to-be-some-problem-with-the-drawing-of-the-polygons/34710).

Summing the direct and IBL lighting results can also result in clipping artifacts when both light sources are near their maxima. See this image from @ggetz, as reported in https://github.com/CesiumGS/cesium/pull/12070#issuecomment-2217986123...

This could be a one-line fix in the `createRegion` function in `Cesium3DTile`. We already check if the transform has been changed, and if so, return a `TileOrientedBoundingBox` instead of a...

I think the overall approach makes sense, although perhaps @lilleyse should chime in. My main concern: calling `model.resetDrawCommands` from `Scene.pickMetadata` would effectively rebuild the shaders at every frame, which would...

As observed by @catnuko in https://github.com/CesiumGS/cesium/issues/12392, the current default `msaaSamples` can be GPU-intensive when coupled with higher values of `resolutionScale`. Thinking about @jjspace's suggestion for a future "High, medium, low"...

Hi @mat-ran, thanks for this report. I can reproduce the problem. Using `Scene.pickPosition` instead of `camera.getPickRay` + `globe.pick` gives the same result -- see this [updated Sandcastle](https://sandcastle.cesium.com/#c=dVRtb9owEP4rFl/mSpkDtEwro9W6wFY0WipgmyZFqkxyAauOHdkObTbx32fnBZquJR/I3T333PnucXwfZQoyqgBtuFxDKCIptEE7Bo+g0AUS8IgC0CxPyc/Sh8NOVNqBFIYyASrseOhvKBAyoJT1DJuEVWWTRMn0l1Q8rh34xHPwNdUwowWoOxY9gBqihHINZcj3I5mmIAwyEiXsyfl0BAJOx3PBiyEyKnfI/cmnUFS9koimoCjhUj5cGewy6jYCqox9o+K07GQMGwWg8ftev0/63cFHD519IL3zwcBDvW63S7pVe89OfmTAgxLhofb/SSje6mSlqNCJVCmuyW6oUezpjEzHk9vVdPXbJYbC92kcoyjXRqaIu6k0q4ipoUuZqwja6whK7PgQxe/SwlnvnnVyzNXE8uOj3VTVYBCHxATcLgHBzs68KbylIuYvRbCM7PDEMqMRTBz4ugLhw9HFjmpHXmcTW2AqstxcRYZJgZNclC8Il7VOKuVUBRUtbLH2EDdgnDwWtKgSSCY1cwSuRpMIdj/buzpwpCgVQ0pdk8ySYFvAawVbJMIwU7RPOyl9uOwRoab0sF3Qq6JRwZmInY5rOLKDFRuzHTpZeY3PyGxBY5brtnstjd3ma5GEcX4QfOVKqb1qjPLDTQskl6pU95fCKhX3rZi79jmvtex+Mje2QXhBtQW22ZoFJKBARHBgvG77STC7urm7X83vvy3mP27HVfq+pNlXUzxqi5SjZLXmqrk6zN57S0WrIgMym3xd3QezafDdgTteZ6RNweGyafUzSzOpDMoVx4T4BtKM20Fof53b74chkdZVJwiN/Oepo5jtEIsvXvlyoYhTrW0kyTlfsj8Qdi5HvsX/l8ql3Y3YzHeg7PV0sG3vclY5CSEj35qvZxop+ZqqF8z/AA).

Here is a helpful [Sandcastle demonstrating the problem](https://sandcastle.cesium.com/#c=lVTva9swEP1XjrAPDmR2nY02I25YSb40jHbQsU+GRZHPsYgsBUmOyYr/90r+kbhNRjuDwTrdvXt692QqhTawZ1iiglsQWMIcNSty/3cd8+IBrddzKQxhAlU8GE5jEQtaV9IM6fbPcmHk/dPj5PoqtCBpIahhUni0UOoXy9HuD59jAdDWdOF7LduStuey4IyIBTHoW8Bm9xXK1KG416gD1JDuCQK4MwbznQEjXZM9KvuZIXSktFFMbGBN6NalEDh16kDecHvAcrm4yCxVMj/j1gYagh2c5OhzufFW85qStpqATOHTc+9IFZREgy6olVmnBV816gJUQImhGXiolFTD7rQdbh39ALKQpoceW5BeUsu6AtYkMmGVIiIhKjlKl0qVE7MaQcPjeEDCrcje6k40GyCpg8UEyoxx7KbgVHeDSJxy/+juwu8TaDpXsahqgYLgQcJOyTXHHEpmMriBhG2Y0Q7EtUwVqW1IOOyIMkfHnhQKXzv+NGNv/PX66su3cAQhfr5xnc983rdlOGwp/ezzmTR82H8QGn+I0ORdQuPhdDAaRNocOM66gX1n+U7ae1Eo7vl+4O4Lt9A6WBd0i8anWnfTjYJ+aZSwPbDk9sKvACgnWtsd6y3+xP5iPJhFgc0/K+WSJNYMj9YUnBxcWhbOfjRB3/ejwC4vVxop+ZqoN8gv), contributed by a [community member](https://community.cesium.com/t/conversion-problem-with-from-and-to-iso8601-datetime/36430).