Justin Gallardo
Justin Gallardo
@creesch I'm working on building a better test harness for testing changes against a collection of real servers. In the mean time I'll do some manual testing and try to...
Thanks for this report. I'll take a look at this today and see what I can do.
I'm all for that. Honestly this project should probably be deprecated. There are a lot of improvements to be made, but it is becoming a big pile of spaghetti code,...
Here are two that I've played with. https://github.com/gf3/IRC-js https://github.com/twitch-irc/twitch-irc
I'll start heading through the PRs and merge what I can. A big issue we've had is people submitting PRs, and never coming back to respond to comments. It is...
@Jnull It'd be easier to coordinate if you joined ##node-irc on freenode so we could chat.
@paladox you can pass a message to the `client.disconnect(msg, callback)` function to quit with custom message. That said, sending quit manually should probably work, so I'll look into that.
@paladox can you put together a test case that shows this? In my testing, `disconnect(msg)` and `send('QUIT', msg)` both appear to work.
@paladox interesting. I've added a test case(https://github.com/martynsmith/node-irc/blob/master/test/test-quit.js) that verifies that the disconnect message is properly sent. Maybe this is a quirk with the irc server? Also, if you are trying...
I'm +1 to this change. I'm not confident enough in the tests to blindly merge it, so I'll run it on my various bots to try it out.