node-irc icon indicating copy to clipboard operation
node-irc copied to clipboard

Make SASL work for more networks.

Open creesch opened this issue 9 years ago • 3 comments

snoonet.org doesn't return * as the first argument (unless that is intended as a wildcard, meaning the switch statement always has been broken for this case) and will not return 'sasl ' as was assumed but return 'sasl'.

creesch avatar Feb 03 '16 19:02 creesch

@jirwin, I noticed you are most active here. What needs to be done to get this pull request merged?

creesch avatar Feb 09 '16 15:02 creesch

@creesch I'm working on building a better test harness for testing changes against a collection of real servers. In the mean time I'll do some manual testing and try to get this merged.

jirwin avatar Feb 11 '16 18:02 jirwin

Wow ~ I just discovered this problem today and submitted a patch / pull request a few hours ago ~ five years later X-)

jmcparland avatar Nov 04 '21 15:11 jmcparland