Jiren Patel

Results 5 comments of Jiren Patel

Validation error because of crc32c check failure. https://github.com/googleapis/nodejs-storage/blob/61eeb64a6bca194361aacf2a312d27d0e6d63b35/src/file.ts#L1372 - On upload, storage client calculates crc32c after gzip compression. Google storage service is also calculating crc32c on gzip data and send...

Here is the current condition. https://github.com/googleapis/nodejs-storage/blob/71a4f59343bbe9b0c00ebdf68f6fdf9d214727cc/src/file.ts#L1300-L1303 This condition can be change as per data is compress or not. If the gzip header is present then only validate CRC and MD5....

@dazuma I am going to update tag structure for key, value (with metadata - `ttl`) something like this. Please let me know your suggestions. ```ruby class TagMap # @param [Hash,...

> I think including the metadata in `TagValue` is confusing, since that's not how the [spec](https://github.com/census-instrumentation/opencensus-specs/blob/master/tags/TagMap.md) describes the types. What's wrong with the existing classes? Nothing wrong with existing classes....

> @jiren Can you review this and verify it's in line with the current stats code? Yes, look good as per current stats code. Just for information, this example needs...