opencensus-ruby icon indicating copy to clipboard operation
opencensus-ruby copied to clipboard

Fix stats example

Open directionless opened this issue 5 years ago • 5 comments

This fixes the stats example.

~Exporters don’t work.~

But I’m sure my comments are wrong. But it’s a start

directionless avatar Apr 05 '19 19:04 directionless

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

googlebot avatar Apr 05 '19 19:04 googlebot

I signed it!

directionless avatar Apr 05 '19 19:04 directionless

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot avatar Apr 05 '19 19:04 googlebot

@jiren Can you review this and verify it's in line with the current stats code?

dazuma avatar Apr 21 '19 00:04 dazuma

@jiren Can you review this and verify it's in line with the current stats code?

Yes, look good as per current stats code.

Just for information, this example needs to be updated once the Tag metadata code is merged.

jiren avatar Apr 21 '19 07:04 jiren