Jingwei Huang

Results 13 comments of Jingwei Huang

Hi Kyle, thanks for your feedback. Could you please provide the more information about this error? Is it a crash? Can you reproduce it every time? When does this happen?...

In the example code, `FeedCollectionViewController` extends from `FeedBaseViewController`. In base class `FeedBaseViewController`, `getFeedItems()` provides an array of `Layout`. Since your `FeedCollectionViewController` is subclass of `UIViewController`, could you post your `getFeedItems()`?

@kylebrowning For `layoutProvider`, it has to be `(Void) -> T`. For the generics we are using, please refer to `public struct Section`. And also you can take a look on...

Hi @spekke, thanks for your code and findings. I found `LayoutKit` has the compatibility issue with `UIFontDescriptor`. We are looking into it and in the meanwhile, could you use `NSFontAttributeName:...

@spekke I found the issue that by using `UIFontDescriptor`, it provides different leading to compare with the default font, which is constructed by `UIFont` initializer. After I added the font...

@spekke Thanks for your following up. We are using `boundingRect` to measure the size. However, I found `boundingRect` gives the result without respecting `UIFont`'s `leading` , which represents additional space...

@ghmake1y Thanks for your PR. Could you elaborate why `UILabel()` isn't safe? We want to match `LabelLayout` font the same as `UILabel` by default

@jiaopen I don't find this issue. Could you share your Xcode version?

@plamenterziev Thanks for your feedbacks. For your `NSAttributedString`, did you make `Text` and pass to `LabelLayout` initializer or update attributed text in `config`?