LayoutKit icon indicating copy to clipboard operation
LayoutKit copied to clipboard

Create list with limitations/constraints of LabelLayout

Open plamenterziev opened this issue 7 years ago • 5 comments

LabeLayout relies on boundingRect method which does not work in all cases and I think that it would be great from documentation perspective if have a list of all limitations/constraints found so far.

I've spent few hours finding out why boundingRect does not return valid size and it turned out that it does not work if the NSAttributedString has NSParagraphStyle with line break set to NSLineBreakByTruncatingTail and the number of lines is 0

So here is one issue :)

plamenterziev avatar Apr 11 '17 13:04 plamenterziev

@plamenterziev Thanks for your feedbacks. For your NSAttributedString, did you make Text and pass to LabelLayout initializer or update attributed text in config?

jingwei-huang1 avatar Apr 11 '17 16:04 jingwei-huang1

@plamenterziev Could you please also provide the information how you set the NSAttributedString to LayoutLabel?

jingwei-huang1 avatar Apr 11 '17 16:04 jingwei-huang1

@jingwei-huang1 - I am creating the Text and pass to the LabelLayout initializer (have no config)

plamenterziev avatar Apr 18 '17 13:04 plamenterziev

@plamenterziev We can definitely mention this issue in the layout's documentation comments. Do you know of a way to come up with an exhaustive list of such issues?

In the longer term, I'm considering implementing a Layout that would render text to a layer at measurement time, avoiding any boundingRect / UILabel disagreements.

staguer avatar Apr 19 '17 19:04 staguer

@plamenterziev I tried to reproduce the same thing, but I couldn't found the issue. Could you please also provide the code how you set it up?

jingwei-huang1 avatar Apr 20 '17 01:04 jingwei-huang1