jiaoyangChen

Results 11 comments of jiaoyangChen

To use the parameters `dataStream` and `associatedStreams` rather than `dataStreams` property, I changed the input type of 'sc-dial/sc-dial.tsx' file.

> This pull request **fixes 1 alert** when merging [a8b1c28](https://github.com/awslabs/synchro-charts/commit/a8b1c28403f2f19fed51a2cfd37da8881981c0cd) into [5407d84](https://github.com/awslabs/synchro-charts/commit/5407d84072fdcbaf2becff23238485b7f59348fb) - [view on LGTM.com](https://lgtm.com/projects/g/awslabs/synchro-charts/rev/pr-a1ce0f222097198ad375a8fc958c9d617628b7cc) > > **fixed alerts:** > > * 1 for Unused or undefined state property...

> Please re-request review when everything is ready for review, so I know everything is addressed and ready for comment. I guess the last error is there are some problems...

> please clean up the git history - we want one pull request to add one additional commit to the tip of what is on the `main` branch. If there's...

> could we get a snapshot test that actually visualizes this small corner? Done. In cypress file. ![截屏2022-10-12 下午5 14 16](https://user-images.githubusercontent.com/108785049/195302476-3c536eab-1c50-4e42-8529-5a8e39fa2e35.png) > And is there someway we can avoid having...

> on image packages/synchro-charts/cypress/snapshots/dial/dial.spec.ts/renders alarm Warning.snap.png you can see some colission between the icon and the ring This is because the iconSize set by cypress is very large, which is...

> gracefully handle the scenario a `yMin` and `yMax` or omitted from the viewport It displays `0%` if has no unit, or displays the input value and unit if has...

> ensure that there is no message stating 'invalid data' when the latest value is greater than the specified `yMax`. It's not invalid data for the data to be greater...

> > > ensure that there is no message stating 'invalid data' when the latest value is greater than the specified `yMax`. It's not invalid data for the data to...

> looks good, just need to clean up the git history to be a single commit, with a well formatted commit message in a 'conventional commit' style (https://www.conventionalcommits.org/en/v1.0.0/) New PR:...