synchro-charts icon indicating copy to clipboard operation
synchro-charts copied to clipboard

Published 20 hours ago • verified publisher icon awslabs

Add the small rounded corner of a ring and recalculate the label and …

Open jiaoyangChen opened this issue 2 years ago • 4 comments

Overview

Add the small rounded corner of a ring. Recalculate the label and icon positions when the size is updated.

Tests

[Include a link to the passing GitHub action running the test suite here.]

Legal

This project is available under the Apache 2.0 License.

jiaoyangChen avatar Oct 09 '22 11:10 jiaoyangChen

could we get a snapshot test that actually visualizes this small corner?

Done. In cypress file. 截屏2022-10-12 下午5 14 16

And is there someway we can avoid having all this low level path building? Surely there's some library we can utilize?

The path calculation is a little tricky, and that's the only way I can think of it. And we can utilize zRender library(https://github.com/ecomfe/zrender) to get Path. But it was rejected before.

jiaoyangChen avatar Oct 12 '22 09:10 jiaoyangChen

What do you mean by zrender being rejected before?

diehbria avatar Oct 12 '22 15:10 diehbria

on image packages/synchro-charts/cypress/snapshots/dial/dial.spec.ts/renders alarm Warning.snap.png you can see some colission between the icon and the ring

diehbria avatar Oct 12 '22 16:10 diehbria

on image packages/synchro-charts/cypress/snapshots/dial/dial.spec.ts/renders alarm Warning.snap.png you can see some colission between the icon and the ring

This is because the iconSize set by cypress is very large, which is caused by the adaptive ring. If the icon size is set smaller, it will be solved.

jiaoyangChen avatar Oct 13 '22 10:10 jiaoyangChen

gracefully handle the scenario a yMin and yMax or omitted from the viewport

diehbria avatar Oct 27 '22 14:10 diehbria

gracefully handle the scenario a yMin and yMax or omitted from the viewport

It displays 0% if has no unit, or displays the input value and unit if has unit.

jiaoyangChen avatar Oct 28 '22 09:10 jiaoyangChen

ensure that there is no message stating 'invalid data' when the latest value is greater than the specified yMax. It's not invalid data for the data to be greater than yMax

diehbria avatar Nov 01 '22 21:11 diehbria

ensure that there is no message stating 'invalid data' when the latest value is greater than the specified yMax. It's not invalid data for the data to be greater than yMax

Understood. How about ' Data overflow'? Or do you have any suggestion to it?

jiaoyangChen avatar Nov 02 '22 11:11 jiaoyangChen

ensure that there is no message stating 'invalid data' when the latest value is greater than the specified yMax. It's not invalid data for the data to be greater than yMax

Understood. How about ' Data overflow'? Or do you have any suggestion to it?

We can just present no message in this scenario

diehbria avatar Nov 03 '22 15:11 diehbria

ensure that there is no message stating 'invalid data' when the latest value is greater than the specified yMax. It's not invalid data for the data to be greater than yMax

Understood. How about ' Data overflow'? Or do you have any suggestion to it?

We can just present no message in this scenario

Got it.

jiaoyangChen avatar Nov 04 '22 08:11 jiaoyangChen

looks good, just need to clean up the git history to be a single commit, with a well formatted commit message in a 'conventional commit' style (https://www.conventionalcommits.org/en/v1.0.0/)

diehbria avatar Nov 10 '22 16:11 diehbria

looks good, just need to clean up the git history to be a single commit, with a well formatted commit message in a 'conventional commit' style (https://www.conventionalcommits.org/en/v1.0.0/)

New PR: https://github.com/awslabs/synchro-charts/pull/180

jiaoyangChen avatar Nov 11 '22 13:11 jiaoyangChen

closing in favor of https://github.com/awslabs/synchro-charts/pull/180

diehbria avatar Nov 16 '22 17:11 diehbria