Jian-Yang Li

Results 27 comments of Jian-Yang Li

I thought you used the GitHub repository secret to save the ADS key and allow for tests using secret keys. Perhaps I missed something?

>Is the PDF supposed to be included with the source code? What PDF?

I agree. It's more pythonic to integrate examples into documentations. For more complicated examples, the tutorial repository is a good place to go.

I just checked what's in the example directory. Other than two .rst files, there are three ipython notebooks files: estimating-coma-continuum.ipynb - Contains one example, which makes use of @mkelley 's...

@mkelley I'm just randomly browsing through the old issues. Masking `Quantity` type in astropy tables doesn't seem to be a problem by now. The example code snippet that @mommermi showed...

I think a `.append` method that takes either `Row`, `Table`, or `DataClass` as input would work for what we need. Using Michael's example above, something like this: ```python from sbpy.data...

Well, adding those methods would make it conceptually clear. But in the core, both `add_row()` and `join()` will need to use `Table.vstack(join_type='outer')` to accommodate different sets of columns (I think...

Also, I'd like to update the documentation to advocate for not to use the exposed `table` property to change the table, but rather use the mechanisms realized by `DataClass` itself,...

I see, so you want to reuse the API of astropy tables, expanding their functionalities to meet the requirement for `DataClass` but not introducing new method names. OK that does...

@mkelley I just did a PR that implements the functionality as we discussed. I tried to make use of the existing functionalities from astropy Table and DataClass as much as...