sbpy icon indicating copy to clipboard operation
sbpy copied to clipboard

Published 20 hours ago • verified publisher icon NASA-Planetary-Science

Resolve remote testing on PRs

Open mkelley opened this issue 3 years ago • 2 comments
trafficstars

As noted in #345 , we cannot use the NASA ADS API without publicly exposing a secret API key. These tests could be restored if the ads-based tests could be skipped (perhaps using a pytest.mark or a test that the key exists), or if the ads module was used in sandbox mode. Or may be use a combination of the two?

mkelley avatar Jul 06 '22 18:07 mkelley

I thought you used the GitHub repository secret to save the ADS key and allow for tests using secret keys. Perhaps I missed something?

jianyangli avatar Jul 23 '22 02:07 jianyangli

Sorry, I mean for this to be specific to pull requests. We can indeed use the API key with our weekly tests.

mkelley avatar Jul 24 '22 11:07 mkelley