jialei-chen

Please use the dedicated resource `google_discovery_engine_schema` to manage the schema.

Hi reviewer, our resource `CmekConfig` [only has Update/Get/List/Delete methods but doesn't have a Create method](https://screenshot.googleplex.com/7xgpB7QijKrrEvx). I have 2 questions about the implementation. Could you help take a look? Thanks! 1....

> > Hi reviewer, our resource `CmekConfig` [only has Update/Get/List/Delete methods but doesn't have a Create method](https://screenshot.googleplex.com/7xgpB7QijKrrEvx). I have 2 questions about the implementation. Could you help take a look?...

Checked the [[Error message](https://storage.cloud.google.com/ci-vcr-logs/beta/refs/heads/auto-pr-14161/artifacts/6c525531-8deb-49f6-b6e0-b9238e58d359/build-log/recording_build/TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample_recording_test.log)], * Resource `google_kms_key_ring` exists: * https://screenshot.googleplex.com/4ZCC4dChUWhxGr3 * `"projects/ci-test-project-188019/locations/us/keyRings/tftest-shared-keyring-1"` * Resource `google_kms_crypto_key` and `google_kms_crypto_key_version` exist: * https://screenshot.googleplex.com/8ckQiCigB5GTRpL * `"projects/ci-test-project-188019/locations/us/keyRings/tftest-shared-keyring-1/cryptoKeys/tftest-shared-key-1"` * `"projects/ci-test-project-188019/locations/us/keyRings/tftest-shared-keyring-1/cryptoKeys/tftest-shared-key-1/cryptoKeyVersions/1"` * Error was generated while creating...

> @jialei-chen could you clarify the state of this PR? The code looks sufficient, and the bootstrapped key appears to be hooked up correctly, but the API is not handling...

Hi @roaks3, the bug with API was fixed b/359238429#comment28. I re-retriggered the auto tests by "Sync fork -> Update branch", but got timeout. Do you know what happened or do...

Hi reviewer, I checked [Debug log](https://storage.cloud.google.com/ci-vcr-logs/beta/refs/heads/auto-pr-14161/artifacts/d6dcf1b7-b124-4d0b-9511-9727b6b26c1e/recording/TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample.log) above. The error seems to be impacted by "legacy plugin SDK" and I don't think it can be fixed on my side. Specifically, 1....

> Hmm, I think we should be able to resolve this in the PR. If you look at the POST request made for the datastore, it sends the `kmsKeyName` correctly,...

Hi reviewer @zli82016 , I looked into the failed VCR test, tried to use either (1) JSON string or (2) `jsonencode` similar to [this example](https://github.com/GoogleCloudPlatform/magic-modules/blob/d602092a4eaec47ecaae066b0cbbc1b94bd225a8/mmv1/teqqmplates/terraform/examples/qfirebase_web_app_basic.tf.erb#L23) to fix the "whitespace changes"...

> Can you also add the update test for the field `json_schema`? The doc is [here](https://googlecloudplatform.github.io/magic-modules/develop/test/test/#add-an-update-test) Thanks. Sure, will do it later after fixing the create test, since I estimate...