Add schema resource
This PR adds a new resource Schema to product DiscoveryEngine (b/340925271).
Release Note Template for Downstream PRs (will be copied)
`google_discovery_engine_schema`
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 5 files changed, 788 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 788 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 69 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 117 insertions(+))
Tests analytics
Total tests: 17 Passed tests: 8 Skipped tests: 0 Affected tests: 1
Click here to see the affected service packages
- discoveryengine
Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccDiscoveryEngineSchema_discoveryengineSchemaBasicExample
$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDiscoveryEngineSchema_discoveryengineSchemaBasicExample[Error message] [Debug log]
$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 5 files changed, 788 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 788 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 69 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 117 insertions(+))
Tests analytics
Total tests: 17 Passed tests: 8 Skipped tests: 0 Affected tests: 1
Click here to see the affected service packages
- discoveryengine
Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccDiscoveryEngineSchema_discoveryengineSchemaBasicExample
$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDiscoveryEngineSchema_discoveryengineSchemaBasicExample[Error message] [Debug log]
$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 5 files changed, 788 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 788 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 69 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 117 insertions(+))
Tests analytics
Total tests: 9 Passed tests: 8 Skipped tests: 0 Affected tests: 1
Click here to see the affected service packages
- discoveryengine
Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccDiscoveryEngineSchema_discoveryengineSchemaBasicExample
$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDiscoveryEngineSchema_discoveryengineSchemaBasicExample[Error message] [Debug log]
$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 5 files changed, 790 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 790 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 69 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 118 insertions(+))
Tests analytics
Total tests: 9 Passed tests: 8 Skipped tests: 0 Affected tests: 1
Click here to see the affected service packages
- discoveryengine
Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccDiscoveryEngineSchema_discoveryengineSchemaBasicExample
$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDiscoveryEngineSchema_discoveryengineSchemaBasicExample[Error message] [Debug log]
$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$
Hello! I am a robot. Tests will require approval from a repository maintainer to run.
@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.
You can help make sure that review is quick by doing a self-review and by running impacted tests locally.
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 5 files changed, 790 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 790 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 69 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 118 insertions(+))
Tests analytics
Total tests: 9 Passed tests: 8 Skipped tests: 0 Affected tests: 1
Click here to see the affected service packages
- discoveryengine
Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccDiscoveryEngineSchema_discoveryengineSchemaBasicExample
$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDiscoveryEngineSchema_discoveryengineSchemaBasicExample[Error message] [Debug log]
$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$
Hi reviewer @zli82016 , I looked into the failed VCR test, tried to use either (1) JSON string or (2) jsonencode similar to this example to fix the "whitespace changes" error, but they didn't work and the acceptance test still failed.
From the Debug log, there were 6 requests and they all returned successfully as expected.
- Create the dependency resource DataStore
- Get the created dependency resource DataStore
- Create the resource Schema
- Get the created resource Schema
- Delete the resourced Schema
- Delete the dependency resource DataStore
Do you have any idea why it happened and how to fix this?
Hi reviewer @zli82016 , I looked into the failed VCR test, tried to use either (1) JSON string or (2)
jsonencodesimilar to this example to fix the "whitespace changes" error, but they didn't work and the acceptance test still failed.From the Debug log, there were 6 requests and they all returned successfully as expected.
- Create the dependency resource DataStore
- Get the created dependency resource DataStore
- Create the resource Schema
- Get the created resource Schema
- Delete the resourced Schema
- Delete the dependency resource DataStore
Do you have any idea why it happened and how to fix this?
Hope the comment will fix the test.
Can you also add the update test for the field json_schema? The doc is here
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 5 files changed, 790 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 790 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 69 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 118 insertions(+))
Tests analytics
Total tests: 9 Passed tests: 8 Skipped tests: 0 Affected tests: 1
Click here to see the affected service packages
- discoveryengine
Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccDiscoveryEngineSchema_discoveryengineSchemaBasicExample
$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDiscoveryEngineSchema_discoveryengineSchemaBasicExample[Error message] [Debug log]
$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 5 files changed, 812 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 812 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 78 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 118 insertions(+))
Tests analytics
Total tests: 9 Passed tests: 8 Skipped tests: 0 Affected tests: 1
Click here to see the affected service packages
- discoveryengine
Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccDiscoveryEngineSchema_discoveryengineSchemaBasicExample
$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDiscoveryEngineSchema_discoveryengineSchemaBasicExample[Error message] [Debug log]
$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$
Can you also add the update test for the field
json_schema? The doc is here
Thanks. Sure, will do it later after fixing the create test, since I estimate the same JSON string issue will happen for the udpate test.
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 5 files changed, 812 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 812 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 78 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 118 insertions(+))
Tests analytics
Total tests: 9 Passed tests: 8 Skipped tests: 0 Affected tests: 1
Click here to see the affected service packages
- discoveryengine
Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccDiscoveryEngineSchema_discoveryengineSchemaBasicExample
$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDiscoveryEngineSchema_discoveryengineSchemaBasicExample[Error message] [Debug log]
$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 5 files changed, 812 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 812 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 78 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 118 insertions(+))